Skip to content

Adjust setup-miniconda parameters #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Adjust setup-miniconda parameters #195

merged 3 commits into from
Jan 13, 2023

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 13, 2023

This is in hopes of resolving sporadic errors.
Ref: conda-incubator/setup-miniconda#274

Motivation for these changes

...

Implementation details

...

Checklist

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • ...

This is in hopes of resolving sporadic errors.
Ref: <conda-incubator/setup-miniconda#274>
@codecov-commenter
Copy link

Codecov Report

Merging #195 (0b272c6) into main (4da56ec) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   80.03%   80.03%           
=======================================
  Files         170      170           
  Lines       45086    45086           
  Branches     9603     9603           
=======================================
  Hits        36085    36085           
  Misses       6789     6789           
  Partials     2212     2212           

@maresb maresb marked this pull request as ready for review January 13, 2023 10:11
@maresb
Copy link
Contributor Author

maresb commented Jan 13, 2023

I find the "Benchmark" test unconvincing.

@ricardoV94
Copy link
Member

I find the "Benchmark" test unconvincing.

What do you mean?

@maresb
Copy link
Contributor Author

maresb commented Jan 13, 2023

It seems to often fail for no apparent reason. Like here.

@ricardoV94
Copy link
Member

The failure seems exactly like the one for the other jobs before this PR. Perhaps you also need to tweak here?

mamba-version: "*"
channels: conda-forge,defaults
channel-priority: true
python-version: 3.9

@ferrine
Copy link
Member

ferrine commented Jan 13, 2023

@maresb
Copy link
Contributor Author

maresb commented Jan 13, 2023

Ah, thanks! I didn't look closely enough. Hopefully that does it.

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's working!

@ricardoV94 ricardoV94 merged commit 958cd14 into main Jan 13, 2023
@ricardoV94
Copy link
Member

Thanks @maresb! Hopefully it's stable now :)

@maresb maresb deleted the adjust-setup-miniconda branch January 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants