-
Notifications
You must be signed in to change notification settings - Fork 129
Adjust setup-miniconda parameters #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is in hopes of resolving sporadic errors. Ref: <conda-incubator/setup-miniconda#274>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 80.03% 80.03%
=======================================
Files 170 170
Lines 45086 45086
Branches 9603 9603
=======================================
Hits 36085 36085
Misses 6789 6789
Partials 2212 2212 |
I find the "Benchmark" test unconvincing. |
What do you mean? |
It seems to often fail for no apparent reason. Like here. |
The failure seems exactly like the one for the other jobs before this PR. Perhaps you also need to tweak here? pytensor/.github/workflows/test.yml Lines 167 to 170 in 0b272c6
|
It seems to boil down to dependencies resolution https://github.com/pymc-devs/pytensor/actions/runs/3910005116/jobs/6681731220#step:3:544 |
Ah, thanks! I didn't look closely enough. Hopefully that does it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's working!
Thanks @maresb! Hopefully it's stable now :) |
This is in hopes of resolving sporadic errors.
Ref: conda-incubator/setup-miniconda#274
Motivation for these changes
...
Implementation details
...
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance