Propagate static shape in MaxAndArgmax
#206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for these changes
MaxAndArgmax
propagates broadcastable flags but not static shape information. Now we have full shape info. Connected to #203Implementation details
I've updated the test suite to test this in a number of places. I'd appreciate close eyes on this to make sure I did the tests right.
I also
parametrized
a few of the updated tests to help me identify a few cases that were failing. Currently I've left them that way since I figure that less monolithic tests are preferable.Checklist
Major / Breaking Changes
na
New features
as stated
Bugfixes
na
Documentation
Maintenance