Skip to content

Fix numba implementation of empty DimShuffle #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

aseyboldt
Copy link
Member

The previous version returned a scalar instead of an array, which can then lead to errors in later code that expects to receive an array.

Fixes pymc-devs/nutpie#37

Checklist

@ricardoV94
Copy link
Member

You have a float32 downcast issue in your test, otherwise looks good

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just so we don't merge accidentally

@ricardoV94
Copy link
Member

I updated protection settings to require tests to pass before merging

@aseyboldt aseyboldt merged commit 4730d0c into pymc-devs:main Feb 13, 2023
@aseyboldt aseyboldt deleted the fix-numba-reshape branch February 13, 2023 18:31
@ricardoV94 ricardoV94 added the bug Something isn't working label Feb 15, 2023
@ricardoV94 ricardoV94 changed the title Fix numba impl of empty DimShuffle Fix numba implementation of empty DimShuffle Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vectorized Typing error from Numba
3 participants