Fix Scan JAX dispatcher #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Mar 2, 2023
ricardoV94
force-pushed
the
fix_jax_scan_dispatch
branch
2 times, most recently
from
c6a0e5b to
76d27b2
Compare
|
Want to simplify a bit the logic with some of the scan helpers now that I know they exist. Can still be reviewed and tested upon! |
ricardoV94
force-pushed
the
fix_jax_scan_dispatch
branch
from
76d27b2 to
8b89b2a
Compare
|
Cleaned up |
ricardoV94
force-pushed
the
fix_jax_scan_dispatch
branch
4 times, most recently
from
86d84a3 to
b0aa0b9
Compare
Armavica
reviewed
Mar 15, 2023
ricardoV94
force-pushed
the
fix_jax_scan_dispatch
branch
from
b0aa0b9 to
d5ba7fe
Compare
|
@Armavica I addressed some of your suggestions. Feel free to take another stab! |
ricardoV94
force-pushed
the
fix_jax_scan_dispatch
branch
from
d5ba7fe to
7c35a6c
Compare
Armavica
reviewed
Apr 1, 2023
ricardoV94
force-pushed
the
fix_jax_scan_dispatch
branch
from
7c35a6c to
1ba5887
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 80.43% 80.46% +0.03%
==========================================
Files 170 170
Lines 45394 45412 +18
Branches 11088 11087 -1
==========================================
+ Hits 36512 36541 +29
+ Misses 6654 6639 -15
- Partials 2228 2232 +4
|
Armavica
approved these changes
Apr 4, 2023
This was referenced Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Should be working now
NotImplemented: