Fix bug in storage_input alignment of the JAX backend #587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When transpiling functions with Shared RNGs to the JAX backend, we replace the original variables by copies so that we can update them in the same container without changing the data type (JAX PRNGs vs numpy Generator), so that the same shared variable can be reused in other functions, which may use distinct backends.
There was a bug in that this replacement could change the position of the input variable in the FunctionGraph, and disalign it with the pre-defined input_storage list. This PR fixes the bug by forcing the position of the new input variable in the FunctionGraph to be the same as the one in input_storage list.
AFAICT the order of the FunctionGraph inputs is not stored/referenced anywhere internally, so this should be safe.
This showed up when trying to use PyMC VI with the JAX backend.
Related Issue
Checklist
Type of change