Add JAX support for SortOp #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
approved these changes
Mar 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
+ Coverage 80.80% 80.82% +0.02%
==========================================
Files 162 162
Lines 46743 46820 +77
Branches 11419 11438 +19
==========================================
+ Hits 37770 37844 +74
+ Misses 6731 6725 -6
- Partials 2242 2251 +9
|
ricardoV94
requested changes
Mar 4, 2024
Comment on lines
213
to
214
| def sort(arr, *args): | ||
| return jnp.sort(arr, *args) |
There was a problem hiding this comment.
Suggested change
| def sort(arr, *args): | |
| return jnp.sort(arr, *args) | |
| def sort(arr, axis): | |
| return jnp.sort(arr, axis=axis) |
tests/link/jax/test_tensor_basic.py
Outdated
Comment on lines
221
to
226
| def test_sort(): | ||
| x = matrix("x") | ||
| out = pytensor.tensor.sort(x) | ||
| fgraph = FunctionGraph([x], [out]) | ||
| arr = np.array([[1.0, 4.0], [5.0, 2.0]]) | ||
| compare_jax_and_py(fgraph, [arr]) |
There was a problem hiding this comment.
Suggested change
| def test_sort(): | |
| x = matrix("x") | |
| out = pytensor.tensor.sort(x) | |
| fgraph = FunctionGraph([x], [out]) | |
| arr = np.array([[1.0, 4.0], [5.0, 2.0]]) | |
| compare_jax_and_py(fgraph, [arr]) | |
| @pytest.mark.parametrize("axis", [None, -1]) | |
| def test_sort(axis): | |
| x = matrix("x", shape=(2, 2), dtype="float64") | |
| out = pytensor.tensor.sort(x, axis=axis) | |
| fgraph = FunctionGraph([x], [out]) | |
| arr = np.array([[1.0, 4.0], [5.0, 2.0]]) | |
| compare_jax_and_py(fgraph, [arr]) |
ricardoV94
approved these changes
Mar 4, 2024
|
Thanks @HarshvirSandhu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement JAX conversion for SortOp
Related Issue
Checklist
Type of change