Allow defining an OpFromGraph from constant and shared inputs #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a strict flag
Description
This changes make working with OpFromGraph much simpler, as we can fully control the signature of OpFromGraph without having to worry whether the variables we are using to define the inner graph are shared/constants.
This facilitates the work being done in pymc-devs/pymc#6947
Related Issue
OpFromGraph
difficult to subclass due to not allowing shared variables to be positioned explicitly as an input #473Checklist
Type of change