-
Notifications
You must be signed in to change notification settings - Fork 130
Reconcile environment for development and docs building #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe not merge yet. Let me update the documentation first. I opened the PR first though. |
You can click |
Okay I have also updated the documentation. The change should be good for merging. |
Is anyone using the docgen.py script for something other than to generate the html build of the docs? I was just going over it and it basically calls sphinx with different defaults (such as default to building both html and pdf via latex instead of only building html). If it isn't really being used (doc building and PR previews via readthedocs do not use it for example), it is probably best to remove and update the contributing guide a bit more to use the sphinx command directly instead of running docgen script |
environment.yml
Outdated
@@ -37,6 +37,9 @@ dependencies: | |||
- pygments | |||
- pydot | |||
- ipython | |||
- pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be installed from conda forge too, no need to include pip and install from github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I search on conda libraries website I did not find the theme. In the GitHub workflow I also see that it is published on PyPI
only, so I follows that environment.yml in the doc
folder 😅. Can you give me the conda package website like this one: https://anaconda.org/conda-forge/pydata-sphinx-theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one in the doc folder should also be updated then. Link: https://anaconda.org/conda-forge/pymc-sphinx-theme
Agreed. Let me deal with this. |
|
Thanks a ton @HangenYuu |
Description
Updated the environment.yml for developing and docs building locally.
Related Issue
Checklist
Type of change