Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Sign up

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

pymc-devs / pytensor Public

Notifications You must be signed in to change notification settings
Fork 129
Star 456

Code
Issues 250
Pull requests 74
Discussions
Actions
Projects 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

Improved docstrings for Elemwise functions #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

fonnesbeck wants to merge 0 commits into pymc-devs:main from fonnesbeck:main

Closed

Improved docstrings for Elemwise functions #830

fonnesbeck wants to merge 0 commits into pymc-devs:main from fonnesbeck:main

Conversation 11 Commits 0 Checks 0 Files changed

Conversation

Copy link

Member

fonnesbeck commented Jun 18, 2024 •

edited

Loading

Description

Added more robust docstrings and removed the Elemwise docstring that was appended to each function.

Related Issue

Closes DOC: Docstrings for Elemwise Ops are not very helpful #292
Related to #

Checklist

Checked that the pre-commit linting/style checks pass
Included tests that prove the fix is effective or that the new feature works
Added necessary documentation (docstrings and/or example notebooks)
If you are a pro: each commit corresponds to a relevant logical change

Type of change

New feature / enhancement
Bug fix
Documentation
Maintenance
Other (please specify):

Sorry, something went wrong.

All reactions

fonnesbeck requested a review from ricardoV94

June 18, 2024 03:11

ricardoV94 reviewed

View reviewed changes

pytensor/tensor/math.py Outdated Show resolved Hide resolved

ricardoV94 reviewed

View reviewed changes

pytensor/tensor/math.py Outdated Show resolved Hide resolved

ricardoV94 reviewed

View reviewed changes

pytensor/tensor/math.py Outdated Show resolved Hide resolved

ricardoV94 reviewed

View reviewed changes

pytensor/tensor/math.py Outdated Show resolved Hide resolved

ricardoV94 reviewed

View reviewed changes

pytensor/tensor/special.py Outdated Show resolved Hide resolved

Copy link

Member Author

fonnesbeck commented Jun 18, 2024

Not clear why the fast-compile tests are failing here.

All reactions

Sorry, something went wrong.

fonnesbeck requested a review from ricardoV94

June 18, 2024 14:57

Copy link

Member

ricardoV94 commented Jun 19, 2024

Not clear why the fast-compile tests are failing here.

Something must have actually broken. Perhaps the Elemwise decorator was doing something dumb that fails with the new docstrings? Have to investigate

All reactions

Sorry, something went wrong.

ricardoV94 added the docs label

ricardoV94 changed the title ~~Improved docstrings for user-facing functions~~ Improved docstrings for Elemwise functions

fonnesbeck closed this

fonnesbeck force-pushed the main branch from 9d87785 to 231a977 Compare

December 17, 2024 16:40

This was referenced Feb 26, 2025

Add object mode fallback for Numba RandomVariables #1249

Open

Add numpy-like vecdot, vecmat and matvec helpers #1250

Merged

Copy link

Member

twiecki commented Feb 27, 2025

It seems by force-pushing you removed all commits @fonnesbeck. are they still to be found somewhere?

All reactions

Sorry, something went wrong.

Copy link

Member

ricardoV94 commented Feb 27, 2025

Oh :(

All reactions

Sorry, something went wrong.

Copy link

Member Author

fonnesbeck commented Feb 27, 2025

Yeah, I never got around to re-doing this PR. I can work on it this week.

All reactions

Sorry, something went wrong.

Copy link

Member

ricardoV94 commented Feb 27, 2025 •

edited

Loading

Yeah, I never got around to re-doing this PR. I can work on it this week.

We wanted to see if Claude could figure it out. But we need your changes :)

All reactions

Sorry, something went wrong.

fonnesbeck mentioned this pull request

Improve elemwise docstrings #1255

Merged

11 tasks

twiecki mentioned this pull request

Improved docstrings for Elemwise functions #1259

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ricardoV94 Awaiting requested review from ricardoV94

Assignees

No one assigned

Labels

docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DOC: Docstrings for Elemwise Ops are not very helpful

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.