Make zip strict

[ricardoV94]

Description

Subtle bug showed up in pymc-devs/pymc#7370 where a RandomVariable had a wrong signature

[jessegrabowski]

Obviously the original author assumed these could never be different length (and I see why he thought so). Judging by the test, the errors comes from not enough arguments being passed to RV. Is there no way to directly check that? The error generated by the zip would not give much guidance to how to debug the issue relative to something like f"NormalRV expected 2 inputs, got {len(inputs): {", ".join([str(x) for x in inputs])"

[ricardoV94]

Is there no way to directly check that?

There is but I was hoping my lazy fix would fly under the radar. Well it did not :D

[jessegrabowski]

Even if you add a more specific input check, zip should probably still be strict as a last line of defense. So the lazy solution is not implemented in vein!

[ricardoV94]

Even if you add a more specific input check, zip should probably still be strict as a last line of defense. So the lazy solution is not implemented in vein!

That gives me little solace but thank you :D. Mondays are the worst

[Armavica]

Are we interested in a PR making all the zips strict (or explicitly non-strict)? It's a ruff rule that is not enabled for PyTensor: https://docs.astral.sh/ruff/rules/zip-without-explicit-strict/

[ricardoV94]

Are we interested in a PR making all the zips strict (or explicitly non-strict)? It's a ruff rule that is not enabled for PyTensor: https://docs.astral.sh/ruff/rules/zip-without-explicit-strict/

Maybe, do you like it?

[Armavica]

Maybe, do you like it?

No, I love it

[ricardoV94]

Closing in favor of #850