Skip to content

A more low level implementation of vectorize in numba #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 4, 2023
Merged

A more low level implementation of vectorize in numba #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d4e5dcd
Initial version of llvm elemwise impl
aseyboldt Dec 6, 2022
61e7a67
numba reshape should always return an array
aseyboldt Dec 20, 2022
7ecbac7
numba careduce should return an array
aseyboldt Dec 20, 2022
6936d2d
Specialized numba sum impl
aseyboldt Dec 20, 2022
ae122aa
Add shape checking in numba elemwise
aseyboldt Dec 20, 2022
0ed277f
Add typing for some numba elemwise
aseyboldt Dec 20, 2022
79b1037
Remove py310 only strict arg to zip
aseyboldt Dec 20, 2022
e9ab63c
Fix tests and fix scalar numba return types
aseyboldt Dec 21, 2022
05f6ab2
Add cast in numba elemwise between func type and output type
aseyboldt Dec 21, 2022
b93a4f7
numba while condition must be tensor
aseyboldt Dec 21, 2022
bfb91f9
Fix some floatX issues
aseyboldt Dec 21, 2022
84d6fd5
Add benchmark for numba elemwise
aseyboldt Dec 22, 2022
4fedcbe
Fix typo in error message
aseyboldt Jan 3, 2023
462b957
Remove unused helper file
aseyboldt Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pytensor/link/numba/dispatch/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ def in_seq_empty_tuple(x, y):


def to_scalar(x):
raise NotImplementedError()
return np.asarray(x).item()


@numba.extending.overload(to_scalar)
Expand Down Expand Up @@ -543,7 +543,7 @@ def {fn_name}({", ".join(input_names)}):
{index_prologue}
{indices_creation_src}
{index_body}
return z
return np.asarray(z)
"""

return subtensor_def_src
Expand Down Expand Up @@ -665,7 +665,7 @@ def numba_funcify_Shape_i(op, **kwargs):

@numba_njit
def shape_i(x):
return np.shape(x)[i]
return np.asarray(np.shape(x)[i])

return shape_i

Expand Down Expand Up @@ -698,7 +698,7 @@ def numba_funcify_Reshape(op, **kwargs):

@numba_njit
def reshape(x, shape):
return x.item()
return np.asarray(x.item())

else:

Expand Down
Loading