fix: filename can contain ',' (#587) #595
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 21 21
Lines 1771 1771
Branches 333 333
=======================================
Hits 1644 1644
Misses 77 77
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
auvipy
requested changes
May 31, 2025
| @@ -182,7 +182,7 @@ def iter_files(self) -> Generator[Path]: | |||
| record = record_names[0].read_text() | |||
| reader = csv.reader(r for r in record.splitlines()) | |||
| for row in reader: | |||
| filename = row[0] | |||
| filename = ",".join(row[0:-2]) | |||
There was a problem hiding this comment.
shouldn't this change covered by appropriate test?
There was a problem hiding this comment.
IMO the change is too small. even case is rare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #587