Fixtures that save to database silently pass if they don't use the "db" fixture

[ionelmc]

This is very annoying as you don't have clear indication of why your fixture doesn't work. Any database changing actions done in a fixture that doesn't depend on db/transactional_db should raise clear errors indicating the problem.

[ionelmc]

Eg:

@pytest.fixture(scope='module')
def ghost_user():
    return User.objects.create(username='foobar')

@pytest.fixture(scope='module')
def real_user(db):
    return User.objects.create(username='foobar')

def test_that_works(real_user):
    assert User.objects.get(username='foobar') == real_user

def test_that_doesnt_work(ghost_user):
    assert User.objects.get(username='foobar') == real_user # raises ObjectDoesNotExist