Skip to content

Rsync very noisy in quiet mode #471

Open
@yurikhan

Description

@yurikhan

When bringing up test nodes, xdist rsyncs specified trees. The class responsible for that is xdist.workermanage.HostRSync.

In the _report_send_file method, it checks its verbosity level. If it is not 0, it prints out the node spec, local path, and remote path of the file being synchronized.

py.test can be run in quiet mode (-q), in which case its verbosity level will be -1 or lower. Which is not 0, so rsyncing messages flood the terminal.

The fix should be trivial — replace if self._verbose: with if self._verbose > 0: in xdist.workermanage.HostRSync._report_send_file. (Possibly push the threshold up a bit, so flood only happens at -vv or even higher.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions