Docs: is setUpModule/tearDownModule supported?

[flanaman]

The docs say that setUpModule and tearDownModule are not supported:

https://github.com/pytest-dev/pytest/blob/master/doc/en/unittest.rst#unittesttestcase-support

But experience and this

https://github.com/pytest-dev/pytest/blob/master/src/_pytest/python.py#L529

suggest they are. Is this just a case of needing to update the docs or are they only partially supported?

[asottile]

appears to be misleading docs to me:

def setUpModule():
    print(setUpModule.__name__)

def tearDownModule():
    print(tearDownModule.__name__)

def test():
    print(test.__name__)

def test2():
    print(test2.__name__)

$ pytest -v -s t.py
============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.8.3.dev1+gdf435fa8.d20181002, py-1.6.0, pluggy-0.7.1 -- /tmp/t/venv/bin/python3
cachedir: .pytest_cache
rootdir: /tmp/t, inifile:
collected 2 items                                                              

t.py::test setUpModule
test
PASSED
t.py::test2 test2
PASSEDtearDownModule


=========================== 2 passed in 0.02 seconds ===========================

It's even mentioned in the 2.4.0 release!

Looks like this was (erroneously?) introduced in #2656

@flanaman would you like to fix the docs here? :D

[nicoddemus]

Looks like this was (erroneously?) introduced in #2656

Ooops! Clearly it is supported:

pytest/src/_pytest/python.py

Lines 528 to 539 in df435fa

	def setup(self):
	setup_module = _get_xunit_setup_teardown(self.obj, "setUpModule")
	if setup_module is None:
	setup_module = _get_xunit_setup_teardown(self.obj, "setup_module")
	if setup_module is not None:
	setup_module()
	teardown_module = _get_xunit_setup_teardown(self.obj, "tearDownModule")
	if teardown_module is None:
	teardown_module = _get_xunit_setup_teardown(self.obj, "teardown_module")
	if teardown_module is not None:
	self.addfinalizer(teardown_module)

What probably happened is that I searched for "setUpModule" in _pytest/unittest.py when crafting those docs, while this functionality is implemented in python.py. 🤦‍♂️

[pecey]

I can take care of this.

This needs to go away from unittest.rst and from the website. Correct?

[asottile]

Editing the rst is an you need!

[nicoddemus]

@pecey you can even do that from the GitHub web UI directly. 😉

[pecey]

Ah! Will send in a PR.