This repository was archived by the owner on Jan 13, 2021. It is now read-only.
For python2.7 compatibility #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @irachex! Can you please add a test that validates the problem and proves that it's fixed? |
|
@Lukasa 2 testcase added and passed. |
|
I agree, I think the Travis failures are a timing issue related to our attempts to disable SSL cert verification in the tests. That's...pretty annoying. |
|
Want to try rebasing onto the new |
|
@Lukasa Cool! Rebased. |
|
@irachex Thanks so much, this looks perfect! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can't use
body.encode('utf-8')ifbodyis astrinstance in python2.7