Skip to content

Always skip pyrepl tests that contain "can't use pyrepl" #133054

Closed
@sobolevn

Description

@sobolevn

Bug report

Right now there's a pattern in https://github.com/python/cpython/blob/main/Lib/test/test_pyrepl/test_pyrepl.py

that looks like this:

output, exit_code = self.run_repl(commands, env=env)
if "can't use pyrepl" in output:
    self.skipTest("pyrepl not available")

We manually check the error message after run_repl call and then skip the test.
This design is prone to possible errors.

I propose to do this check in run_pyrepl itself.

Linked PRs

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirtopic-replRelated to the interactive shelltype-bugAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions