test_minidom has many empty tests

[zware]

BPO	19683
Nosy	@bitdancer, @karlcow, @zware, @serhiy-storchaka
PRs	gh-63882: Adds tests for xml.dom.minidom #24152
Files	issue19683.patch issue19683.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Edit by TJR: The two patch files, by two different people deleted empty tests. Some version was merged to Python maintenance versions 2.7 and 3.3 (then on Mercurial) in Dec 2013: #63882 (comment). At that time, 3.4.0, released in March 2014, was tip. PR 24152 added docstrings to minidom.py, removed the empty tests, and revised existing tests. The author closed it due to lack of time when requested to split it into multiple PRs.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2013-11-21.15:17:39.634>
labels = ['easy', 'type-feature', 'tests']
title = 'test_minidom has many empty tests'
updated_at = <Date 2021-01-07.13:48:32.590>
user = 'https://github.com/zware'

bugs.python.org fields:

activity = <Date 2021-01-07.13:48:32.590>
actor = 'karlcow'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2013-11-21.15:17:39.634>
creator = 'zach.ware'
dependencies = []
files = ['32901', '33258']
hgrepos = []
issue_num = 19683
keywords = ['patch', 'easy']
message_count = 21.0
messages = ['203637', '203642', '203643', '204781', '204806', '204834', '205274', '206637', '206639', '206641', '206642', '206873', '206939', '206979', '209897', '209899', '353793', '353835', '384561', '384575', '384576']
nosy_count = 7.0
nosy_names = ['r.david.murray', 'karlcow', 'python-dev', 'zach.ware', 'serhiy.storchaka', 'Julian.Gindi', 'ajitesh.gupta']
pr_nums = ['24152']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19683'
versions = ['Python 3.4']

Linked PRs

• gh-128508: Add some docstrings to xml.dom.minidom #128477
• gh-63882: Comment out empty test_minidom tests #128948
• gh-63882: Implement some test_minidom tests #132879
• gh-63882: Use self.assert* in test_minidom #133000
• [3.13] gh-63882: Use self.assert* methods in test_minidom (GH-133000) #133024
• gh-63882: Break down and tests in test_minidom #133026
• [3.13] gh-63882: Implement some test_minidom tests (GH-132879) #133029
• [3.13] gh-63882: Break down and tests in test_minidom (GH-133026) #133451

[zware]

Many of the tests in test_minidom on 2.7 are empty, that is they are defined as "def testSomeFunction(self): pass".

I've marked this issue as "easy" since I suspect a lot of the tests can be either backported from 3.x, or removed if they don't exist in 3.x.

[bitdancer]

Well, we generally don't backport tests unless we are fixing related bugs. I think this should be left alone.

[zware]

In that case, the empty tests should be removed, since they currently report success on doing nothing.

[ajiteshgupta]

I have attached a patch. I deleted all the empty tests.

[serhiy-storchaka]

Rather than removing these empty tests it will be better implement them. Otherwise we can accidentally break the code.

I see a lot of empty tests on 3.x.

[bitdancer]

On tip it would indeed be better to implement them. The deletion is only for the released branches.

[JulianGindi]

I agree that they should be implemented. I'll fill them in and submit a patch in a day or so.

[python-dev]

New changeset 2737c0e7ba71 by Zachary Ware in branch '2.7':
Issue bpo-19683: Removed empty tests from test_minidom.
http://hg.python.org/cpython/rev/2737c0e7ba71

New changeset 5e510117b71a by Zachary Ware in branch '3.3':
Issue bpo-19683: Removed empty tests from test_minidom. Patch by Ajitesh Gupta.
http://hg.python.org/cpython/rev/5e510117b71a

[zware]

Thanks for the removal patch, Ajitesh!

Julian, are you still working on implementing the tests on default?

[JulianGindi]

I have not started yet, wasn't completely sure of the status of this. I'll get going filling in those tests to the best of my ability.

[zware]

Alright, sounds good.

[JulianGindi]

So, it seems that there are many seemingly redundant tests and many tests whose intentions are unclear. I think this might be better suited for someone who has more experience with the xml minidom module. I have uploaded the work I have done but it is not complete.