Skip to content

gh-118948: add support for ISO 8601 basic format to datetime #120553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

gh-118948: add support for ISO 8601 basic format to datetime #120553

wants to merge 15 commits into from

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jun 15, 2024 •
edited
Loading

In addition to date and datetime, datetime.time also supports ISO 8601 basic format (the rationale is to make it consistent).

📚 Documentation preview 📚: https://cpython-previews--120553.org.readthedocs.build/

@picnixz picnixz requested review from pganssle and abalkin as code owners June 15, 2024 14:20
@bedevere-app bedevere-app bot mentioned this pull request Jun 15, 2024
Open
nineteendo
nineteendo reviewed Jun 15, 2024
View reviewed changes
nineteendo
nineteendo reviewed Jun 15, 2024
View reviewed changes
@ericsnowcurrently ericsnowcurrently removed their request for review June 17, 2024 19:27
@picnixz picnixz added the stale Stale PR or inactive for long period of time. label Jan 23, 2025
StanFromIreland
StanFromIreland reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs some polishing and simplification in my opinion, especially tests, but looks very good in general :-)

picnixz
picnixz commented Mar 22, 2025
View reviewed changes
picnixz
picnixz commented Mar 22, 2025
View reviewed changes
picnixz
picnixz commented Mar 22, 2025
View reviewed changes
StanFromIreland
StanFromIreland approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can leave refactoring for later. LGTM :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nineteendo nineteendo nineteendo left review comments

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @nineteendo @StanFromIreland