GH-125413: Add pathlib.Path.info attribute
#127730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a path object is generated by `PathBase.iterdir()`, then its `_info` attribute now stores a `os.DirEntry`-like object that can be used to query the file type. This removes any need for a `_scandir()` method. Currently the `_info` attribute is private and only guaranteed to be populated in paths from `iterdir()`. Later on, I'm hoping to rename it to `info` and ensure that it's populated for all kinds of paths (this probably involves adding a `pathlib.FileInfo` class.) In the pathlib ABCs, `info` will replace `stat()` as the lowest-level abstract file status querying mechanism.
|
Steve - hopefully this helps address the issues you raised in #127377, but perhaps I'm only moving the problem around here. |
|
I think this is just moving stuff around. It might end up being the right places, but let's see the Discourse discussion play out a bit first. |
barneygale
changed the title
_scandir() with _info_scandir() with _status
barneygale
changed the title
_scandir() with _statuspathlib.Path.status attribute
|
I've revised the PR to be a more complete implementation of what I described on the forum, mostly as a demonstration/proof-of-concept at this stage. |
|
Right, I think this is ready for review. Alyssa, sorry if this seems like deja-vu! |
barneygale
changed the title
pathlib.Path.status attributepathlib.Path.info attribute
17 tasks
encukou
reviewed
Jan 10, 2025
Co-authored-by: Petr Viktorin <[email protected]>
encukou
approved these changes
Jan 13, 2025
|
Thank you Petr :) I'll wait another month until I merge, in case Alyssa or Steve have feedback |
|
I'll merge this on Friday if there's no further feedback. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
pathlib.Path.infoattribute, which stores an object implementing thepathlib.types.PathInfoprotocol (also new). The object supports querying the file type and internally cachingos.stat()results. Path objects generated byPath.iterdir()are initialised with status information fromos.DirEntryobjects, which is gleaned from scanning the parent directory.The
PathInfoprotocol has four methods:exists(),is_dir(),is_file()andis_symlink().os.DirEntryobjects from pathlib #125413