gh-133042: disable HACL* HMAC on Emscripten #133064
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lukasdoe Would this fix your issue? |
|
yes! I can confirm that this fixes the issue for me. Thx, well done :) |
|
Ok, I think it's better to just disable HACL* HMAC on Emscripten for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with
freeze.pybut we may eventually need to do it.I plan to leave on Monday evening and I won't have access to my dev session until May 8th or something like that.
@hugovk Feel free to revert #132438 and #133012.
@hoodmane Feel free to take over this branch if you want. Also, please first confirm that disabling HACL* HMAC actually solves the issue (ISTM that it kinda works but I needed to run
makemanually because I had some issues with my system-wide Python that is too old foremcc& co)._Py_LibHacl_Hacl_Hash_*#133042