-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-127604: Optimize -ldl usage on platforms that use dlopen for libFFI. #133081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
!buildbot iOS |
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 297f242 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133081%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Nope... looks like that hasn't done it. I'll take another look in the morning if nobody beats me to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine and I'm pretty sure there is a cleaner and alternative way to do it but I'm also pretty sure that it would require more steps and a more complicate configuration so I think we should live with this first.
More generally, I think we need to have a function that cleans up the flags to remove duplicate ones.
Wait how come? then where is the one coming from...? |
Actually, it looks like it worked because before we had (in the "Compile build Python" step):
and now we have
So two warnings go eliminated. It remains to check what the others are. We also have 2 warnings less in the "Compile host Python" step. |
Note that the duplicate gcc -ldl -o _bootstrap_python Modules/getbuildinfo.o [...] \
Programs/_bootstrap_python.o Modules/getpath.o -ldl -framework CoreFoundation |
#133040 modified the handling of
-ldl
, resulting in multiple copies of-ldl
being included in link commands.#133071 modified this handling to minimise a lot of those usages; but on platforms that use
dlopen()
(macOS and iOS), there was still some duplicated use. This PR cleans up that usage.faulthandler
#127604