gh-74232: Add a note about roundtrip of non-float numerics in CSV #134963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
docs
Yzi-Li
reviewed
May 31, 2025
| Some numeric types, such as :class:`bool`, :class:`~fractions.Fraction`, | ||
| or :class:`~enum.IntEnum`, have a string representation that cannot be | ||
| converted to :class:`float`. | ||
| They cannot be read in the :data:`QUOTE_NONNUMERIC` and |
There was a problem hiding this comment.
Suggested change
| They cannot be read in the :data:`QUOTE_NONNUMERIC` and | |
| They cannot be read in the :data:`!QUOTE_NONNUMERIC` and |
There was a problem hiding this comment.
While this is in the description for QUOTE_NONNUMERIC, but it is quite distant from the beginning, so a link will not harm.
bskinn
approved these changes
Jun 2, 2025
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2025
…SV (pythonGH-134963) (cherry picked from commit e814f43) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2025
…SV (pythonGH-134963) (cherry picked from commit e814f43) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-135048 is a backport of this pull request to the 3.14 branch. |
|
GH-135049 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 2, 2025
…CSV (GH-134963) (GH-135049) (cherry picked from commit e814f43) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 2, 2025
…CSV (GH-134963) (GH-135048) (cherry picked from commit e814f43) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--134963.org.readthedocs.build/