Revert "bpo-31961: subprocess now accepts path-like args (GH-4329)" #5912
Conversation
…)" This reverts commit dd42cb7.
Lib/test/test_subprocess.py
Outdated
| @@ -1179,7 +1179,7 @@ def test_nonexisting_with_pipes(self): | |||
| msvcrt.CrtSetReportFile(report_type, msvcrt.CRTDBG_FILE_STDERR) | |||
|
|
|||
| try: | |||
| subprocess.Popen(cmd, | |||
| subprocess.Popen([cmd], | |||
There was a problem hiding this comment.
Do not revert 5537646. It should be a bugfix no matter what. cmd is a list and comes through the repr into this python code string as a list. using [cmd] would make it a list of lists which is never desirable here.
|
We do need a Misc/NEWS entry - either adding one saying the previous change was undone, or removing the Misc/NEWS entry that was added for the original change. I've asked Ned on the bug which way we should go with that. |
serhiy-storchaka
force-pushed
the
revert-31961
branch
from
c301c04 to
d13d0a5
Compare
|
Is this ready to go? |
|
Only if we will decide to revert this feature completely. If we will decide to keep it see the bugfix PR #5914. |
|
I'll give @gpshead a few hours to chime in since it is early in the day for him. |
|
The clock has run out for 3.7.0b2. I'm going to push this and backport it to 3.7. We can decide later what to do for both 3.8 and 3.7. |
|
@ned-deily: Please replace |
|
Thanks @serhiy-storchaka for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
…)" (pythonGH-5912) * Revert "bpo-31961: subprocess now accepts path-like args (pythonGH-4329)" This reverts commit dd42cb7. (cherry picked from commit be50a7b) Co-authored-by: Serhiy Storchaka <[email protected]>
…honGH-4329)" (python#5912)" This reverts commit be50a7b.
|
GH-5931 is a backport of this pull request to the 3.7 branch. |
This reverts commit dd42cb7
and commit 5537646.https://bugs.python.org/issue31961