Update wording on committing.rst. #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezio-melotti
commented
Sep 5, 2017
committing.rst
Outdated
|
|
||
| Is the change ready for committing? | ||
| ----------------------------------- | ||
| This page is aimed to core developers, and cover the steps required to |
| @@ -1,18 +1,17 @@ | |||
| .. _committing: | |||
There was a problem hiding this comment.
Should the filename and the label be updated too?
| @@ -93,6 +92,8 @@ making a complete patch. | |||
| Commit Style | |||
| ------------ | |||
|
|
|||
| .. move this to pullrequest | |||
There was a problem hiding this comment.
Committing is now done by contributors, so this section doesn't belong here anymore.
Something could be said about the commit message used while squashing.
This was referenced Sep 5, 2017
Merged
Mariatta
approved these changes
Sep 6, 2017
AA-Turner
pushed a commit
to AA-Turner/devguide
that referenced
this pull request
Jun 17, 2022
* Update wording on committing.rst. * Fix typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.