Don't run test suite on 32bit Windows #13672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think testing the different architecture gains us anything, and [we don't build mypyc compiled wheels for win32 anyway](https://github.com/mypyc/mypy_mypyc-wheels/blob/aabe075c7abe8baa0b212cc14e7ab607dffa6934/build_wheel.py#L35), so there shouldn't be a difference between the two. This should provide a nice speedup to the test suite as well. These tests were initially introduced in #8327.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
mr-c
added a commit
to mr-c/mypy
that referenced
this pull request
Feb 7, 2023
Debian does build 32bit (on Linux), so this is an easy way to support them This reverts commit 330f79b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think testing the different architecture gains us anything, and we don't build mypyc compiled wheels for win32 anyway, so there shouldn't be a difference between the two. This should provide a nice speedup to the test suite as well.
These tests were initially introduced in #8327.