Translate CSV Module rst:71 to rst:152 #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cschan1828 merged 5 commits into python:3.12 from rockleona:csv-0806

Aug 15, 2023

Collaborator

rockleona commented Aug 12, 2023

Collaborator Author

rockleona commented Aug 12, 2023

啊....是不是因為我共用前幾天的 PR 的 Branch 造成多個 commit .....@@

Collaborator

mattwang44 commented Aug 13, 2023

啊....是不是因為我共用前幾天的 PR 的 Branch 造成多個 commit .....@@

對歐，可以學一下 git rebase 指令怎麼使用，如果不確定怎麼做再請你找我討論 🙏🏽


          Translate rst:71 to rst:152

eb1190e

rockleona force-pushed the csv-0806 branch from b24cc99 to eb1190e Compare

August 14, 2023 16:09

Collaborator

mattwang44 commented Aug 14, 2023 •

edited

Loading

@cschan1828 想請問最近有空來幫忙 review 嗎？

cschan1828 self-requested a review

August 15, 2023 01:23

cschan1828 reviewed

View reviewed changes

library/csv.po Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 requested changes

View reviewed changes

Collaborator

cschan1828 left a comment

Thanks for the commit!

有些常見的動詞其實可以考慮直接找中文慣用動詞來用哦，保留原文主要是指專有名詞。


          Update with Reviewer's comment

ef073f1

Collaborator Author

rockleona commented Aug 15, 2023

Hi @cschan1828 , thanks for the review!

感謝你的細心，再麻煩幫我看看了，感謝！


          HOTFIX

8c69508

cschan1828 reviewed

View reviewed changes

library/csv.po Outdated Show resolved Hide resolved

cschan1828 reviewed

View reviewed changes

Collaborator

cschan1828 left a comment

相當不錯了，僅想再釐清一些小細節。

cschan1828 enabled auto-merge (squash)

August 15, 2023 12:01


          Fix Missing Translation

cschan1828 reviewed

View reviewed changes

Collaborator

cschan1828 left a comment

很通用的詞語直接用中文即可。

library/csv.po Outdated Show resolved Hide resolved


          Updated and Simplfied

ccb0bde

cschan1828 approved these changes

View reviewed changes

Collaborator

cschan1828 left a comment

LGTM! Approved.

mattwang44 approved these changes

View reviewed changes

Collaborator

mattwang44 left a comment

Thanks guys!

cschan1828 merged commit 732575d into python:3.12

beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request


          Translate CSV Module rst:71 to rst:152 (python#582)

00c75fc

* Translate rst:71 to rst:152

* Update with Reviewer's comment

* HOTFIX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet