Skip to content

fix(tools): Fix linter to not depend on docker #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2022
Merged

fix(tools): Fix linter to not depend on docker #1301

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eddc47c
fix(tools): Fix linter to not depend on docker
narendasan Aug 23, 2022
564b4c4
Update linter.yml
narendasan Aug 23, 2022
dfa678c
Update linter.yml
narendasan Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 25 additions & 19 deletions .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,25 +25,25 @@ jobs:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Docker login
uses: docker/login-action@v1
- name: Set up Python 3.9.4
uses: actions/setup-python@v2
with:
registry: docker.pkg.github.com
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Run image
python-version: 3.9.4
- name: Setup env
run: |
docker pull docker.pkg.github.com/pytorch/tensorrt/docgen:latest
docker run -it -d --name cpplinter -e GITHUB_TOKEN=$GITHUB_TOKEN -v $GITHUB_WORKSPACE:/workspace -v $GITHUB_EVENT_PATH:/GITHUB_EVENT.json -w /workspace docker.pkg.github.com/pytorch/tensorrt/docgen:latest
docker exec cpplinter bash -c "cp /workspace/docker/WORKSPACE.docker /workspace/WORKSPACE"
sudo ln -s $GITHUB_EVENT_PATH /GITHUB_EVENT.json
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
- name: Install dependencies
run: |
docker exec cpplinter bash -c "pip3 install -r /workspace/.github/scripts/requirements.txt"
docker exec cpplinter bash -c "pip3 install -r /workspace/requirements-dev.txt"
pip3 install -r $GITHUB_WORKSPACE/.github/scripts/requirements.txt
pip3 install -r $GITHUB_WORKSPACE/requirements-dev.txt
- name: Lint C++
run: docker exec cpplinter bash -c "cd /workspace && python3 /workspace/.github/scripts/run_cpp_linter.py"
run: |
cd $GITHUB_WORKSPACE
python3 $GITHUB_WORKSPACE/.github/scripts/run_cpp_linter.py
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

py-linting:
name: Python Linting
Expand All @@ -65,22 +65,28 @@ jobs:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up Python 3.9.4
uses: actions/setup-python@v2
with:
python-version: 3.9.4
- name: Docker login
uses: docker/login-action@v1
with:
registry: docker.pkg.github.com
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Run image
- name: Setup env
run: |
docker pull docker.pkg.github.com/pytorch/tensorrt/docgen:latest
docker run -it -d --name pylinter -e GITHUB_TOKEN=$GITHUB_TOKEN -v $GITHUB_WORKSPACE:/workspace -v $GITHUB_EVENT_PATH:/GITHUB_EVENT.json -w /workspace docker.pkg.github.com/pytorch/tensorrt/docgen:latest
docker exec pylinter bash -c "cp /workspace/docker/WORKSPACE.docker /workspace/WORKSPACE"
sudo ln -s $GITHUB_EVENT_PATH /GITHUB_EVENT.json
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
- name: Install dependencies
run: |
docker exec pylinter bash -c "pip3 install -r /workspace/.github/scripts/requirements.txt"
docker exec pylinter bash -c "pip3 install -r /workspace/requirements-dev.txt"
pip3 install -r $GITHUB_WORKSPACE/.github/scripts/requirements.txt
pip3 install -r $GITHUB_WORKSPACE/requirements-dev.txt
- name: Lint Python
run: docker exec pylinter bash -c "cd /workspace && python3 /workspace/.github/scripts/run_py_linter.py"
run: |
cd $GITHUB_WORKSPACE
python3 $GITHUB_WORKSPACE/.github/scripts/run_py_linter.py
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}