chore: add missing test dependencies #1442
Conversation
|
Hi @drupol! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
drupol
force-pushed
the
patch-1
branch
2 times, most recently
from
13b4cb2 to
9a06082
Compare
While packaging this module for Nix, I noticed during the tests that `flask` and `flask-compress` modules were missing from the `setup.py` file.
|
Is there anything left to do in this PR ? |
|
@jjuncho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Nope! Just need to check it against our internal tests, and once those pass I'll merge! Thank you for opening this PR! |
|
Thanks! |
While packaging this module for Nix (NixOS/nixpkgs#356087), I noticed during the tests that
flaskandflask-compressmodules were missing from thesetup.pyfile.