Skip to content

Lock to numpy 1.23.5 for reinforcement_learning to avoid removed np.bool #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

charles-juicelabs
Copy link

The gym library used in the reinforcement_learning example uses np.bool which is deprecated in numpy 1.20 and removed in numpy 1.24. This is further complicated by gym itself being deprecated and not accepting updates that might fix the problem at its source; see openai/gym#3258.

Fixed by locking the numpy version for this example to 1.23.5.

The gym library used in the reinforcement_learning example uses np.bool
which is deprecated in numpy 1.20 and removed in numpy 1.24.  This is
further complicated by gym itself being deprecated and not accepting
updates that might fix the problem at its source; see
openai/gym#3258.

Fixed by locking the numpy version for this example to 1.23.5.
@facebook-github-bot
Copy link
Contributor

Hi @charles-juicelabs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit e5ccadf
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/67b5278886ddf50008aa5799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants