Skip to content

Fixup op_slice negative start arguments #10122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

3l1
Copy link
Contributor

@3l1 3l1 commented Apr 11, 2025

Summary: Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353

@3l1 3l1 requested a review from digantdesai as a code owner April 11, 2025 21:27
Copy link

pytorch-bot bot commented Apr 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10122

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 002f903 with merge base a664d7b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72728353

@3l1
Copy link
Contributor Author

3l1 commented Apr 11, 2025

@pytorchbot label "topic: not user facing"

3l1 added a commit to 3l1/executorch that referenced this pull request Apr 11, 2025
Summary:

 Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353
@3l1 3l1 force-pushed the export-D72728353 branch from 06055f2 to 0b45deb Compare April 11, 2025 23:11
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72728353

3l1 added a commit to 3l1/executorch that referenced this pull request Apr 11, 2025
Summary:
Pull Request resolved: pytorch#10122

 Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353
@3l1 3l1 force-pushed the export-D72728353 branch from 0b45deb to c51a465 Compare April 11, 2025 23:16
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72728353

3l1 added a commit to 3l1/executorch that referenced this pull request Apr 11, 2025
Summary:
Pull Request resolved: pytorch#10122

 Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353
@3l1 3l1 force-pushed the export-D72728353 branch from c51a465 to 0461eff Compare April 11, 2025 23:23
3l1 added a commit to 3l1/executorch that referenced this pull request Apr 11, 2025
Summary:

 Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353
@3l1 3l1 force-pushed the export-D72728353 branch from 0461eff to a8b3c4d Compare April 11, 2025 23:39
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72728353

3l1 added a commit to 3l1/executorch that referenced this pull request Apr 11, 2025
Summary:
Pull Request resolved: pytorch#10122

 Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353
@3l1 3l1 force-pushed the export-D72728353 branch from a8b3c4d to db92169 Compare April 11, 2025 23:41
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72728353

3l1 added a commit to 3l1/executorch that referenced this pull request Apr 11, 2025
Summary:
Pull Request resolved: pytorch#10122

 Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353
@3l1 3l1 force-pushed the export-D72728353 branch 2 times, most recently from bae6a93 to c9d9379 Compare April 13, 2025 21:37
3l1 added a commit to 3l1/executorch that referenced this pull request Apr 13, 2025
Summary:

 Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72728353

3l1 added a commit to 3l1/executorch that referenced this pull request Apr 13, 2025
Summary:
Pull Request resolved: pytorch#10122

 Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353
@3l1 3l1 force-pushed the export-D72728353 branch from c9d9379 to 5071d6a Compare April 13, 2025 21:39
Summary:
Pull Request resolved: pytorch#10122

 Fixup op_slice negative start arguments

Reviewed By: digantdesai

Differential Revision: D72728353
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72728353

@3l1 3l1 force-pushed the export-D72728353 branch from 5071d6a to 002f903 Compare April 13, 2025 21:45
@facebook-github-bot facebook-github-bot merged commit c352672 into pytorch:main Apr 14, 2025
84 checks passed
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
Differential Revision: D72728353

Pull Request resolved: pytorch#10122
@zingo zingo added the module: arm Issues related to arm backend label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: arm Issues related to arm backend topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants