Fix timespec_get not compatiable for AOSP OS Android N14 #10240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekxu
requested review from
jackzhxng,
iseeyuan,
larryliu0820 and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10240
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc6684a with merge base 47fb157 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73136434 |
|
@pytorchbot label "topic: not user facing" |
Summary: timespec_get was introduced in the pull request D72181347 for the windows time count. The MARCO gate was for ANDROID_API < 29, however, some other AOSP based OS does not support this function too Reviewed By: larryliu0820 Differential Revision: D73136434
derekxu
force-pushed
the
export-D73136434
branch
from
ee3a3b7 to
bc6684a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73136434 |
derekxu
changed the title
larryliu0820
approved these changes
Apr 16, 2025
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Differential Revision: D73136434 Pull Request resolved: pytorch#10240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D73136434