Skip to content

Rename convert_pt2 #10378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Rename convert_pt2 #10378

merged 1 commit into from
Apr 24, 2025

Conversation

mcremon-meta
Copy link
Contributor

Summary: The name is misleading since it also does prepare.

Reviewed By: zonglinpeng

Differential Revision: D73440519

@mcremon-meta mcremon-meta requested a review from tarun292 as a code owner April 23, 2025 00:33
Copy link

pytorch-bot bot commented Apr 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10378

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit c3879ca with merge base 2837867 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73440519

mcremon-meta added a commit that referenced this pull request Apr 24, 2025
Summary:

The name is misleading since it also does prepare.

Reviewed By: zonglinpeng

Differential Revision: D73440519
Summary:
Pull Request resolved: #10378

The name is misleading since it also does prepare.

Reviewed By: zonglinpeng

Differential Revision: D73440519
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73440519

@facebook-github-bot facebook-github-bot merged commit 1432243 into main Apr 24, 2025
83 of 86 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D73440519 branch April 24, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants