Skip to content

Arm backend: Update node visitors to support TOSA 1.0 #10390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 23, 2025

Conversation

per
Copy link
Collaborator

@per per commented Apr 23, 2025

Summary

Updates node visitors to support TOSA 1.0 specification.

Test plan

Tested through public and internal CI.

cc @digantdesai @freddan80 @zingo @oscarandersson8218

per added 9 commits April 23, 2025 14:06
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I0d05617a7bb59d1ab9f8775414ebe9d457b95872
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Ida37b112ae88510e3683a17f09def784f8320ea2
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Ie62afe580d6c6675739c64640ce190b53df4135e
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I231e94207bc356b0965bf3858eefe00e57562a90
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I333f45b5d7d6eac2595d39a9d099b62cb285e1ef
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I04a2f820082abeb636e7a14099e627217c09ca1e
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: If6a980c724e3b1658aa6ab55eb70927cf86e5863
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: Ia67431491d5c287e8ee1fe6674ebf5fe3903b612
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I3f133d55feac211be6196f4d6811feff97ade98c
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 23, 2025
@per per requested a review from digantdesai as a code owner April 23, 2025 12:58
Copy link

pytorch-bot bot commented Apr 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10390

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit a528854 with merge base 334af4a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@per per requested a review from zingo April 23, 2025 12:59
@zingo
Copy link
Collaborator

zingo commented Apr 23, 2025

Lint error and MacOS error is unrelated

@zingo zingo merged commit a0ca486 into pytorch:main Apr 23, 2025
167 of 170 checks passed
SS-JIA added a commit that referenced this pull request Apr 23, 2025
* main:
  [ET-VK] Enable int8 tiled compute shader to be used with buffer tensors (#10415)
  Revert "Migrate elementwise_util callers to the variants with out_dtypes in template arguments" (#10411)
  Revert "Save some size in dtype_util when dtype selective build is not in use" (#10410)
  Generalize view_copy fusion.
  Add job_arn  to benchmark result (#10372)
  Revert "Minibench refactor (#10376)" (#10405)
  Revert "Arm backend: Populate __init__.py for quantizer and Arm root" (#10395)
  Arm backend: Convert assert to throw ValueError in op_log (#10392)
  Arm backend: Add Tutorial to Example tab on the Docs page (#10386)
  Arm backend: Update node visitors to support TOSA 1.0 (#10390)
  Arm backend: Make it easier to generate non delegated/quantized PTEs (#10387)
  Arm backend: Allow --quantize in non delegated using aot_arm_compiler (#10385)
  Arm backend: Set REGIONCFG registers of the Ethos-U (#10388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants