Skip to content

Add data path to runner #10445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

Add data path to runner #10445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edcc432
Add data path to runner
lucylq Apr 24, 2025
c08fc4e
Update on "Add data path to runner"
lucylq Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion examples/models/llama/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ DEFINE_string(
"llama2.pte",
"Model serialized in flatbuffer format.");

DEFINE_string(data_path, "", "Data file for the model.");

DEFINE_string(tokenizer_path, "tokenizer.bin", "Tokenizer stuff.");

DEFINE_string(prompt, "The answer to the ultimate question is", "Prompt.");
Expand Down Expand Up @@ -49,6 +51,11 @@ int32_t main(int32_t argc, char** argv) {
// and users can create their own DataLoaders to load from arbitrary sources.
const char* model_path = FLAGS_model_path.c_str();

std::optional<std::string> data_path = std::nullopt;
if (!FLAGS_data_path.empty()) {
data_path = FLAGS_data_path.c_str();
}

const char* tokenizer_path = FLAGS_tokenizer_path.c_str();

const char* prompt = FLAGS_prompt.c_str();
Expand All @@ -74,7 +81,7 @@ int32_t main(int32_t argc, char** argv) {
#endif
// create llama runner
// @lint-ignore CLANGTIDY facebook-hte-Deprecated
example::Runner runner(model_path, tokenizer_path);
example::Runner runner(model_path, tokenizer_path, data_path);

if (warmup) {
// @lint-ignore CLANGTIDY facebook-hte-Deprecated
Expand Down
Loading