Arm backend: Add decomposition pass for aten.ne #10475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a DecomposeNotEqualPass that rewrites `aten.ne` and its variants
(e.g. `aten.ne_`, `aten.ne.Scalar`) into a combination of supported TOSA
ops:
ne(x, y) → logical_not(eq(x, y))
This decomposition is necessary since TOSA does not define a NOT_EQUAL
operator. The pass ensures compatibility with both MI and BI TOSA
profiles by emitting only supported ops (`eq` and `logical_not`), and is
integrated into the ArmPassManager pipeline accordingly.
Change-Id: I095e833702c57f55331aaeeee0189b6a092f9319
Signed-off-by: Sebastian Larsson <[email protected]>
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10475
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c259b10 with merge base 9e59c19 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a DecomposeNotEqualPass that rewrites
aten.neand its variants (e.g.aten.ne_,aten.ne.Scalar) into a combination of supported TOSA ops:ne(x, y) → logical_not(eq(x, y))
This decomposition is necessary since TOSA does not define a NOT_EQUAL operator. The pass ensures compatibility with both MI and BI TOSA profiles by emitting only supported ops (
eqandlogical_not), and is integrated into the ArmPassManager pipeline accordingly.cc @digantdesai @freddan80 @per @zingo @oscarandersson8218