Add device type (public, private) and id #10496
Open
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also enable Apple benchmark there. This depends on pytorch/test-infra#6579 Signed-off-by: Huy Do <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10496
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 46b6eab with merge base fa89efa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Signed-off-by: Huy Do <[email protected]>
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
This reverts commit b415af0.
Signed-off-by: Huy Do <[email protected]>
huydhn
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
huydhn
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
Signed-off-by: Huy Do <[email protected]>
huydhn
changed the title
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
huydhn
requested review from
jackzhxng,
iseeyuan,
larryliu0820 and
swolchok
as code owners
guangy10
approved these changes
Apr 26, 2025
|
Regarding We discovered the we where missing --recursive on git submodule update in some of our script maybe it might help you to to add it if not there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also enable Apple benchmark there. This depends on pytorch/test-infra#6579
(Revert b415af0 for testing as it currently breaks building Apple benchmark app, I'll put it back before landing cc @shoumikhin )
Testing
https://hud.pytorch.org/benchmark/llms?startTime=Sat%2C%2019%20Apr%202025%2007%3A11%3A18%20GMT&stopTime=Sat%2C%2026%20Apr%202025%2007%3A11%3A18%20GMT&granularity=day&lBranch=enable-apple-benchmark-private-device&lCommit=46b6eab37da51c83304353df4d403ccbb9991ec4&rBranch=enable-apple-benchmark-private-device&rCommit=46b6eab37da51c83304353df4d403ccbb9991ec4&repoName=pytorch%2Fexecutorch&benchmarkName=&modelName=All%20Models&backendName=All%20Backends&modeName=All%20Modes&dtypeName=All%20DType&deviceName=All%20Devices&archName=All%20Platforms
where the private device is marked private.