Use single rounding as default for TOSA lowering #4591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SaoirseARM
commented
Aug 8, 2024
SaoirseARM
commented
- Use single rounding at rescale to int8
- Minor refactor of op_addmm to use shared functions
Change-Id: Iba787ae70dffd7d6e2665b77cbc220f3e53ecb25
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4591
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d655065 with merge base 9a4f32d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label 'partner: arm' |
pytorch-bot
bot
added
the
partner: arm
|
@pytorchbot label ciflow/trunk |
|
Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help. |
digantdesai
approved these changes
Aug 13, 2024
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Aug 15, 2024
Differential Revision: D61240443 Pull Request resolved: pytorch#4591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.