Skip to content

[ET-VK] Miscellaneous fixes for Vulkan docs #5972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Oct 8, 2024

Stack from ghstack (oldest at bottom):

Differential Revision: D64022818

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Oct 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5972

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 5836959 with merge base aad548c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SS-JIA added a commit that referenced this pull request Oct 8, 2024
ghstack-source-id: 7d00995
Pull Request resolved: #5972
@pytorch-bot pytorch-bot bot added ciflow/periodic module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ labels Oct 8, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024
@SS-JIA
Copy link
Contributor Author

SS-JIA commented Oct 8, 2024

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

SS-JIA added a commit that referenced this pull request Oct 8, 2024
Pull Request resolved: #5972

## Context

Implement various fixes to Vulkan delegate while performing QA for Vulkan docs. I elected to package everything into this one diff so that it is easy to cherrypick into the 0.4 release.


@imported-using-ghimport

Differential Revision: [D64022818](https://our.internmc.facebook.com/intern/diff/D64022818/)
ghstack-source-id: 246752851
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64022818

SS-JIA added a commit that referenced this pull request Oct 8, 2024
Pull Request resolved: #5972

## Context

Implement various fixes to Vulkan delegate while performing QA for Vulkan docs. I elected to package everything into this one diff so that it is easy to cherrypick into the 0.4 release.


@imported-using-ghimport

Differential Revision: [D64022818](https://our.internmc.facebook.com/intern/diff/D64022818/)
ghstack-source-id: 246753076
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64022818

@facebook-github-bot
Copy link
Contributor

@SS-JIA merged this pull request in 513d166.

@SS-JIA
Copy link
Contributor Author

SS-JIA commented Oct 8, 2024

@pytorchbot cherry-pick --onto release/0.4 -c

Copy link

pytorch-bot bot commented Oct 8, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: expected one argument

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@SS-JIA
Copy link
Contributor Author

SS-JIA commented Oct 8, 2024

@pytorchbot cherry-pick --onto release/0.4 -c docs

pytorchbot pushed a commit that referenced this pull request Oct 8, 2024
Summary:
Pull Request resolved: #5972

## Context

Implement various fixes to Vulkan delegate while performing QA for Vulkan docs. I elected to package everything into this one diff so that it is easy to cherrypick into the 0.4 release.

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: jorgep31415

Differential Revision: D64022818

Pulled By: SS-JIA

fbshipit-source-id: 35782970e9db1ab33154ccbae2e10c77d911c041
(cherry picked from commit 513d166)
@pytorchbot
Copy link
Collaborator

Cherry picking #5972

The cherry pick PR is at #5986 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

jackzhxng pushed a commit that referenced this pull request Oct 8, 2024
Miscellaneous fixes for Vulkan docs (#5972)

Summary:
Pull Request resolved: #5972

## Context

Implement various fixes to Vulkan delegate while performing QA for Vulkan docs. I elected to package everything into this one diff so that it is easy to cherrypick into the 0.4 release.

imported-using-ghimport

Test Plan: Imported from OSS

Reviewed By: jorgep31415

Differential Revision: D64022818

Pulled By: SS-JIA

fbshipit-source-id: 35782970e9db1ab33154ccbae2e10c77d911c041
(cherry picked from commit 513d166)

Co-authored-by: Stephen Jia <[email protected]>
@SS-JIA SS-JIA deleted the gh/SS-JIA/109/head branch January 24, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants