Skip to content

Arm backend: Remove unused github ci git setup #8833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zingo
Copy link
Collaborator

@zingo zingo commented Feb 28, 2025

Setup.sh has changed how things are installed and a git user is not needed anymore.

cc @digantdesai @freddan80 @per @oscarandersson8218

Copy link

pytorch-bot bot commented Feb 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8833

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit 5bad5a5 with merge base 4236e5b (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025
@zingo zingo added topic: not user facing partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Feb 28, 2025
@zingo
Copy link
Collaborator Author

zingo commented Feb 28, 2025

Interesting, the FVP timeout on the arm-backend when running should not be related to this change as this would have caused havoc during initial setup. But there is no hurry for this change, so Ill create a patch to bump the timeout and we can rerun this jobs to make sure. I assume the github machines can be a bit slow during heavy workloads so it would make sense to have a bigger value anyway.

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should timeout without this charge often?

@zingo
Copy link
Collaborator Author

zingo commented Mar 5, 2025

I would expect it to, but don't see much, but when looking more closely there are not many jobs running with trunk flag.
If we need this urgently it should be unrelated to to this patch. I have patch on internal review that bumps the timeout from 4min to 10min so my plan is to merge it first and reuse this job to check "green" status.

@zingo
Copy link
Collaborator Author

zingo commented Mar 5, 2025

I assume it could fail more/less depending on loads of the github machines as the timeout is in "normal time" but the FVP is simulating and running in whatever time it got to run on on the current virtual machine.

@zingo zingo force-pushed the Arm-backend-Remove-unused-github-ci-git-setup branch 3 times, most recently from ac0b4f0 to 6a82871 Compare March 20, 2025 16:01
@zingo zingo force-pushed the Arm-backend-Remove-unused-github-ci-git-setup branch 2 times, most recently from ec63d8e to 2f4f6e6 Compare March 28, 2025 14:11
zingo and others added 2 commits April 3, 2025 14:58
Setup.sh has changed how things are installed and a git user is not
needed anymore.

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: Ia2c212f55742ff5b61a1a2c658e574a5b441720c
@zingo zingo force-pushed the Arm-backend-Remove-unused-github-ci-git-setup branch from 08508b3 to f59ec16 Compare April 3, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants