Skip to content

[cadence][g3] enable fp32 permute #9053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions backends/cadence/aot/functions_fusion_g3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
- op: clamp.Tensor_out
kernels:
- arg_meta: null
kernel_name: cadence::impl::G3::clamp_tensor_out
kernel_name: cadence::impl::G3::clamp_Tensor_out

- op: clone.out
kernels:
Expand Down Expand Up @@ -81,12 +81,12 @@
- op: lt.Scalar_out
kernels:
- arg_meta: null
kernel_name: cadence::impl::G3::lt_scalar_out
kernel_name: cadence::impl::G3::lt_Scalar_out

- op: lt.Tensor_out
kernels:
- arg_meta: null
kernel_name: cadence::impl::G3::lt_tensor_out
kernel_name: cadence::impl::G3::lt_Tensor_out

- op: mul.out
kernels:
Expand Down Expand Up @@ -155,7 +155,7 @@
- op: where.self_out
kernels:
- arg_meta: null
kernel_name: cadence::impl::G3::where_out
kernel_name: cadence::impl::G3::where_self_out

- op: native_layer_norm.out
kernels:
Expand Down
2 changes: 1 addition & 1 deletion backends/cadence/fusion_g3/operators/op_clamp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ Tensor& clamp_out(
return out;
}

Tensor& clamp_tensor_out(
Tensor& clamp_Tensor_out(
KernelRuntimeContext& ctx,
const Tensor& in,
const optional<Tensor>& min_opt,
Expand Down
4 changes: 2 additions & 2 deletions backends/cadence/fusion_g3/operators/op_lt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace impl {
namespace G3 {
namespace native {

Tensor& lt_tensor_out(
Tensor& lt_Tensor_out(
KernelRuntimeContext& ctx,
const Tensor& a,
const Tensor& b,
Expand Down Expand Up @@ -141,7 +141,7 @@ Tensor& lt_tensor_out(
return out;
}

Tensor& lt_scalar_out(
Tensor& lt_Scalar_out(
KernelRuntimeContext& ctx,
const Tensor& a,
const Scalar& b,
Expand Down
2 changes: 1 addition & 1 deletion backends/cadence/fusion_g3/operators/op_permute_copy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,4 +157,4 @@ Tensor& permute_copy_out(
} // namespace native
} // namespace G3
} // namespace impl
} // namespace cadence
} // namespace cadence
2 changes: 1 addition & 1 deletion backends/cadence/fusion_g3/operators/op_where.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace impl {
namespace G3 {
namespace native {

Tensor& where_out(
Tensor& where_self_out(
KernelRuntimeContext& ctx,
const Tensor& cond,
const Tensor& a,
Expand Down
8 changes: 8 additions & 0 deletions backends/cadence/fusion_g3/operators/targets.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ def define_operator(name: str, deps: list[str] | None = None) -> None:
OPERATORS = [
"add",
"cat",
"clamp",
"lt",
"rsqrt",
"sigmoid",
"sqrt",
"tanh",
"transpose_copy",
"where",
"dequantize",
"mul",
"native_layer_norm",
Expand Down
42 changes: 26 additions & 16 deletions backends/cadence/utils/facto_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,29 @@


def apply_tensor_contraints(op_name: str, tensor_constraints: list[object]) -> None:
additional_tensor_constraints = [
cp.Dtype.In(lambda deps: [torch.int, torch.float]),
cp.Dtype.NotIn(lambda deps: [torch.int64, torch.float64]),
cp.Value.Ge(lambda deps, dtype, struct: -(2**4)),
cp.Value.Le(lambda deps, dtype, struct: 2**4),
cp.Rank.Ge(lambda deps: 1),
cp.Size.Ge(lambda deps, r, d: 1),
cp.Size.Le(lambda deps, r, d: 2**9),
]

match op_name:
case "where.self":
additional_tensor_constraints = [
cp.Dtype.In(lambda deps: [torch.float, torch.int, torch.bool]),
cp.Dtype.NotIn(lambda deps: [torch.int64, torch.float64]),
cp.Value.Ge(lambda deps, dtype, struct: -(2**4)),
cp.Value.Le(lambda deps, dtype, struct: 2**4),
cp.Rank.Ge(lambda deps: 1),
cp.Size.Ge(lambda deps, r, d: 1),
cp.Size.Le(lambda deps, r, d: 2**9),
]
case "sigmoid.default" | "rsqrt.default":
tensor_constraints.extend(
additional_tensor_constraints.extend(
[
cp.Dtype.In(lambda deps: [torch.float]),
cp.Rank.Le(lambda deps: 2**2),
Expand All @@ -33,45 +53,35 @@ def apply_tensor_contraints(op_name: str, tensor_constraints: list[object]) -> N
]
)
case "mean.dim":
tensor_constraints.extend(
additional_tensor_constraints.extend(
[
cp.Dtype.In(lambda deps: [torch.float]),
cp.Rank.Le(lambda deps: 2**2),
]
)
case "exp.default":
tensor_constraints.extend(
additional_tensor_constraints.extend(
[
cp.Rank.Le(lambda deps: 2**3),
cp.Value.Ge(lambda deps, dtype, struct: -(2**2)),
cp.Value.Le(lambda deps, dtype, struct: 2**2),
]
)
case "slice_copy.Tensor":
tensor_constraints.extend(
additional_tensor_constraints.extend(
[
cp.Rank.Le(lambda deps: 2),
cp.Value.Ge(lambda deps, dtype, struct: 1),
cp.Value.Le(lambda deps, dtype, struct: 2),
]
)
case _:
tensor_constraints.extend(
additional_tensor_constraints.extend(
[
cp.Rank.Le(lambda deps: 2**2),
]
)
tensor_constraints.extend(
[
cp.Dtype.In(lambda deps: [torch.int, torch.float]),
cp.Dtype.NotIn(lambda deps: [torch.int64, torch.float64]),
cp.Value.Ge(lambda deps, dtype, struct: -(2**4)),
cp.Value.Le(lambda deps, dtype, struct: 2**4),
cp.Rank.Ge(lambda deps: 1),
cp.Size.Ge(lambda deps, r, d: 1),
cp.Size.Le(lambda deps, r, d: 2**9),
]
)
tensor_constraints.extend(additional_tensor_constraints)


def apply_scalar_contraints(op_name: str) -> list[ScalarDtype]:
Expand Down
Loading