Skip to content

Arm backend: Add CEIL Operator #9267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

maddun01
Copy link
Collaborator

@maddun01 maddun01 commented Mar 14, 2025

  • Update unary operator factory with CEIL op
  • Rename and refactor test_floor to handle similar ops

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@maddun01 maddun01 requested a review from digantdesai as a code owner March 14, 2025 11:23
Copy link

pytorch-bot bot commented Mar 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9267

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit fd99680 with merge base 059e4b0 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @maddun01!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@maddun01
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

Copy link

pytorch-bot bot commented Mar 14, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Copy link

pytorch-bot bot commented Mar 17, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@mansnils mansnils added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Mar 17, 2025
@ashutosh-arm ashutosh-arm added topic: not user facing CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 17, 2025
Copy link

pytorch-bot bot commented Mar 18, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Update unary operator factory with CEIL op and refactor test_floor to
handle similar ops.

Change-Id: I1ab7a51400597cec782208d4abb5467cbcd228d6
Signed-off-by: Madeleine Dunn <[email protected]>
Copy link

pytorch-bot bot commented Mar 20, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@ashutosh-arm ashutosh-arm merged commit 31d3545 into pytorch:main Mar 24, 2025
163 of 167 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants