Skip to content

Arm backend: improve common.parameterize decorator #9358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Mar 18, 2025

  • Set xfails to strict to detect if failing tests start working
  • Add possibility to pass expected Error type

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Set xfails to strict to detect if failing tests start working
- Add possibility to pass expected Error type

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I594e6ade5e57ad7024457934bad45a3c1fa5c4fc
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Mar 18, 2025
Copy link

pytorch-bot bot commented Mar 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9358

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7008e06 with merge base 31890cb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2025
@Erik-Lundell
Copy link
Collaborator Author

CI failures unrelated from what I can tell

@zingo zingo merged commit 5cd973c into pytorch:main Mar 20, 2025
163 checks passed
oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025
- Set xfails to strict to detect if failing tests start working
- Add possibility to pass expected Error type

Signed-off-by: Erik Lundell <[email protected]>
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
- Set xfails to strict to detect if failing tests start working
- Add possibility to pass expected Error type

Signed-off-by: Erik Lundell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants