-
Notifications
You must be signed in to change notification settings - Fork 573
Arm Backend: Add New DecomposeSilu pass to arm_pass_manager #9448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm Backend: Add New DecomposeSilu pass to arm_pass_manager #9448
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9448
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 684b4b3 with merge base d64c410 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Updated permissions, so you should be able to run ci and merge. |
@@ -0,0 +1,149 @@ | |||
# Copyright (c) Meta Platforms, Inc. and affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no tests for SDPA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were no tests added because it was not a new function essentially, just a new call with the idea is that it is tested elsewhere. We have tested it functionally just not with a unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding test_sdpa.py would ensure we can lower and run it. Where else it is tested? Couldn't find it in the test/ops dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is tested from the QNN delegate but I can add unit tests here also! I will push that when I can ( probably Monday )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, had some issues and went on holidays, came back to more issues so I have removed SDPA for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silu part LGTM. Add SDPA tests?
* Adds DecomposeSilu pass * Adds Tests for DecomposeSilu Signed-off-by: Ryan O'Shea <[email protected]> Change-Id: Ib9f15d04c4c06d92d38cc9e6297145980052e673
23c11c7
to
54d7dee
Compare
Huggingface fails seems unrelated |
…9448) * Adds DecomposeSilu pass * Adds Tests for DecomposeSilu Signed-off-by: Ryan O'Shea <[email protected]>
Change-Id: Ib9f15d04c4c06d92d38cc9e6297145980052e673
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218