Skip to content

Create a CoreML inmemoryfs pybinding target #9482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2025
Merged

Create a CoreML inmemoryfs pybinding target #9482

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71ad31c
split targets
jathu Mar 21, 2025
bb755a1
address comments
jathu Mar 21, 2025
4c09e91
address comments
jathu Mar 21, 2025
588fa40
address pybind include comment
jathu Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions backends/apple/coreml/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ endif()

option(COREML_BUILD_EXECUTOR_RUNNER "Build CoreML executor runner." OFF)

set(CMAKE_OSX_DEPLOYMENT_TARGET 10.15)

# inmemoryfs sources
set(INMEMORYFS_SOURCES
runtime/inmemoryfs/inmemory_filesystem.cpp
Expand Down Expand Up @@ -229,3 +231,18 @@ install(
INCLUDES
DESTINATION ${_common_include_directories}
)

# We only care about building the pybinding when building for macOS wheels.
if(EXECUTORCH_BUILD_COREML AND EXECUTORCH_BUILD_PYBIND)
if(NOT TARGET pybind11::pybind11)
add_subdirectory(${EXECUTORCH_ROOT}/third-party/pybind11 ${CMAKE_CURRENT_BINARY_DIR}/pybind11)
endif()

pybind11_add_module(executorchcoreml SHARED runtime/inmemoryfs/inmemory_filesystem_py.cpp)

target_compile_options(executorchcoreml PRIVATE -mmacosx-version-min=${CMAKE_OSX_DEPLOYMENT_TARGET})
if(CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
target_compile_options(executorchcoreml PRIVATE -g)
endif()
target_link_libraries(executorchcoreml PRIVATE coreml_util coreml_inmemoryfs)
endif()
Loading