Fix exir.load/save to handle named data store map #9485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9485
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 46b8443 with merge base 94ec549 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71601647 |
tarun292
added a commit
that referenced
this pull request
Mar 21, 2025
Summary: After named data store map was added recently to edge dialect the support for serializing/deserializing named data store map was missing in exir.load/save. This diff adds that and also adds a test to check for this. Reviewed By: pssrawat Differential Revision: D71601647
tarun292
force-pushed
the
export-D71601647
branch
from
7372f01 to
c69610c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71601647 |
tarun292
added a commit
that referenced
this pull request
Mar 21, 2025
Summary: Pull Request resolved: #9485 After named data store map was added recently to edge dialect the support for serializing/deserializing named data store map was missing in exir.load/save. This diff adds that and also adds a test to check for this. Reviewed By: pssrawat Differential Revision: D71601647
tarun292
force-pushed
the
export-D71601647
branch
from
c69610c to
b776a18
Compare
tarun292
added a commit
that referenced
this pull request
Mar 21, 2025
Summary: After named data store map was added recently to edge dialect the support for serializing/deserializing named data store map was missing in exir.load/save. This diff adds that and also adds a test to check for this. Reviewed By: pssrawat Differential Revision: D71601647
tarun292
force-pushed
the
export-D71601647
branch
from
b776a18 to
7a5596b
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
Summary: After named data store map was added recently to edge dialect the support for serializing/deserializing named data store map was missing in exir.load/save. This diff adds that and also adds a test to check for this. Reviewed By: pssrawat Differential Revision: D71601647
facebook-github-bot
force-pushed
the
export-D71601647
branch
from
7a5596b to
d87f989
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71601647 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D71601647 |
tarun292
added a commit
that referenced
this pull request
Mar 21, 2025
Summary: Pull Request resolved: #9485 After named data store map was added recently to edge dialect the support for serializing/deserializing named data store map was missing in exir.load/save. This diff adds that and also adds a test to check for this. Reviewed By: pssrawat Differential Revision: D71601647
tarun292
force-pushed
the
export-D71601647
branch
from
d87f989 to
03f04ba
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 22, 2025
Summary: After named data store map was added recently to edge dialect the support for serializing/deserializing named data store map was missing in exir.load/save. This diff adds that and also adds a test to check for this. Reviewed By: pssrawat Differential Revision: D71601647
facebook-github-bot
force-pushed
the
export-D71601647
branch
from
03f04ba to
bcc515b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71601647 |
Summary: After named data store map was added recently to edge dialect the support for serializing/deserializing named data store map was missing in exir.load/save. This diff adds that and also adds a test to check for this. Reviewed By: pssrawat Differential Revision: D71601647
facebook-github-bot
force-pushed
the
export-D71601647
branch
from
bcc515b to
46b8443
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71601647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: After named data store map was added recently to edge dialect the support for serializing/deserializing named data store map was missing in exir.load/save. This diff adds that and also adds a test to check for this.
Differential Revision: D71601647