Skip to content

Add build_optimized_size_test.sh #9840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 22, 2025
Merged

Add build_optimized_size_test.sh #9840

merged 14 commits into from
Apr 22, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Apr 2, 2025

Adding a developer-facing size test script for a non-embedded-centric use case (optimized ops, exceptions on, etc.).

swolchok added 14 commits March 18, 2025 17:32
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9840

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 153735d with merge base 1572381 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@@ -0,0 +1,57 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we trigger this? Add it to CI? Also is it possible to re-use https://github.com/pytorch/executorch/blob/main/test/build_size_test.sh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we trigger this? Add it to CI?

As the description says, it is meant for development use.

is it possible to re-use

No, that script wants to disable exceptions, which is appropriate in the embedded systems context but not the "everything else" context. Optimized kernels are not for the embedded systems context AIUI.

@swolchok swolchok requested a review from kirklandsign April 2, 2025 18:02
Base automatically changed from gh/swolchok/416/head to main April 4, 2025 17:15
@swolchok swolchok merged commit c0593ff into main Apr 22, 2025
81 checks passed
@swolchok swolchok deleted the gh/swolchok/417/head branch April 22, 2025 19:12
@swolchok swolchok added release notes: devtools Changes to dev tooling, for example the debugger & profiler topic: not user facing and removed topic: not user facing labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: devtools Changes to dev tooling, for example the debugger & profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants