Replace IValue::toString()->string() with IValue::toStringRef() (#184)

alexbeloi · facebook-github-bot · commit e5ab4866e7d7 · 2022-09-23T12:42:35.000-07:00
Summary: Pull Request resolved: #184 ATT: for pytorch/multiply Reviewed By: jaybean-dev Differential Revision: D39707244 fbshipit-source-id: 34362c4f243657909dc06be41f1d7087f59ea979
diff --git a/multipy/runtime/test_deploy.cpp b/multipy/runtime/test_deploy.cpp
@@ -500,7 +500,7 @@ TEST(TorchpyTest, TestPyYAML) {
   EXPECT_EQ(1, load.attr("__getitem__")({"a"}).toIValue().toInt());
 
   auto dump = I.global("yaml", "dump")({load});
-  EXPECT_EQ(kDocument, dump.toIValue().toString()->string());
+  EXPECT_EQ(kDocument, dump.toIValue().toStringRef());
 }
 #endif
 
diff --git a/multipy/runtime/test_deploy_gpu.cpp b/multipy/runtime/test_deploy_gpu.cpp
@@ -137,6 +137,6 @@ TEST(TorchpyTest, TestPyYAML) {
   EXPECT_EQ(1, load.attr("__getitem__")({"a"}).toIValue().toInt());
 
   auto dump = I.global("yaml", "dump")({load});
-  EXPECT_EQ(kDocument, dump.toIValue().toString()->string());
+  EXPECT_EQ(kDocument, dump.toIValue().toStringRef());
 }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -500,7 +500,7 @@ TEST(TorchpyTest, TestPyYAML) {`
`500`	`500`	`EXPECT_EQ(1, load.attr("__getitem__")({"a"}).toIValue().toInt());`
`501`	`501`
`502`	`502`	`auto dump = I.global("yaml", "dump")({load});`
`503`		`- EXPECT_EQ(kDocument, dump.toIValue().toString()->string());`
	`503`	`+ EXPECT_EQ(kDocument, dump.toIValue().toStringRef());`
`504`	`504`	`}`
`505`	`505`	`#endif`
`506`	`506`
Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,6 @@ TEST(TorchpyTest, TestPyYAML) {`
`137`	`137`	`EXPECT_EQ(1, load.attr("__getitem__")({"a"}).toIValue().toInt());`
`138`	`138`
`139`	`139`	`auto dump = I.global("yaml", "dump")({load});`
`140`		`- EXPECT_EQ(kDocument, dump.toIValue().toString()->string());`
	`140`	`+ EXPECT_EQ(kDocument, dump.toIValue().toStringRef());`
`141`	`141`	`}`
`142`	`142`	`#endif`