Modify dockerfile to use latest cmake on ubuntu18.04 docker image. #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
|
@anirbanr-fb-r2p has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 89.06% 89.06%
=======================================
Files 67 67
Lines 3888 3888
=======================================
Hits 3463 3463
Misses 425 425 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
PaliC
requested changes
Sep 6, 2022
There was a problem hiding this comment.
Make sure to remove the cmake install from conda so that we're using the right version
Line 63 in 6db7f55
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
Good catch. |
|
@anirbanr-fb-r2p has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
PaliC
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title; by default the image seems to have cmake3.10. This change should update cmake to latest version (3.19+ ideally).
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: