multipy/libpython: strip debug symbols by default #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ezyang
approved these changes
Oct 18, 2022
d4l3k
force-pushed
the
strip-libpython
branch
from
e99619a to
f71f473
Compare
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d4l3k
force-pushed
the
strip-libpython
branch
from
f71f473 to
da129d0
Compare
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d4l3k
force-pushed
the
strip-libpython
branch
from
da129d0 to
0259839
Compare
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d4l3k
force-pushed
the
strip-libpython
branch
2 times, most recently
from
94a4eda to
a752737
Compare
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d4l3k
force-pushed
the
strip-libpython
branch
2 times, most recently
from
9871284 to
e22e02b
Compare
d4l3k
force-pushed
the
strip-libpython
branch
from
e22e02b to
d1c3451
Compare
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ubuntu18.04/centos7 aren't compatible with libpython installed from Conda since they're using pre 2.32 binutils which is incompatible with binaries built with later versions of binutils due to a debug info compression issue.
This also supports older cmake versions + supports PyTorch egglink + some requirements tweaks to get tests passing.
This strips the debug info by default so you can build deploy on all systems.
https://wiki.gentoo.org/wiki/Project:Toolchain/Binutils_2.32_upgrade_notes/elfutils_0.175:_unable_to_initialize_decompress_status_for_section_.debug_info
Test plan:
GitHub CI